Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme:modal): support build-in and focus button #1828

Merged
merged 3 commits into from
Sep 17, 2024
Merged

feat(theme:modal): support build-in and focus button #1828

merged 3 commits into from
Sep 17, 2024

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Aug 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Aug 14, 2024 •
edited
Loading

Preview is ready!

@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.87%. Comparing base (da2fea1) to head (e74dd0f).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
packages/theme/src/services/modal/modal.helper.ts 86.36% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1828      +/-   ##
==========================================
- Coverage   94.89%   94.87%   -0.03%     
==========================================
  Files         315      315              
  Lines        8911     8929      +18     
  Branches     1688     1698      +10     
==========================================
+ Hits         8456     8471      +15     
- Misses        381      382       +1     
- Partials       74       76       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk merged commit 145de7d into master Sep 17, 2024
7 of 9 checks passed
@cipchk cipchk deleted the feat-mh-focus branch September 17, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cipchk